Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable zeroing workgroup memory for compute shaders. #575

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This is a performance improvement for shader compilation.

See gfx-rs/wgpu#5508

This is a performance improvement for shader compilation.

See gfx-rs/wgpu#5508
@waywardmonkeys waywardmonkeys added this to the Vello 0.2 release milestone May 13, 2024
src/wgpu_engine.rs Outdated Show resolved Hide resolved
src/wgpu_engine.rs Outdated Show resolved Hide resolved
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the Default::default version running on my phone with no issues and the expected performance improvement

So once we apply that suggestion, I'm happy for this to land.

Co-authored-by: Lixou <82600264+DasLixou@users.noreply.github.com>
@waywardmonkeys
Copy link
Contributor Author

Used the proposed change and set merge when ready as I am in bed to sleep.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue May 13, 2024
Merged via the queue into linebender:main with commit 1daf2a4 May 13, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the disable-workgroup-memory-zeroing branch May 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants