Workaround to avoid full hang #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the scale factor becomes unreasonably large, the number of subdivisions of an Euler spiral into lines grows, making the flatten stage take too long. This patch just bounds the number of subdivisions, so it will eventually make progress. It will be slow, but not hang. A better solution would be to aggressively cull so it only generates geometry inside the viewport, but that is considerably more complicated. Workaround for #548
|
Given the amount of pain involved in this, I think that maybe having a comment in one of the implementations would be reasonable to explain that this particular |
xStrom
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the scale factor becomes unreasonably large, the number of subdivisions of an Euler spiral into lines grows, making the flatten stage take too long.
This patch just bounds the number of subdivisions, so it will eventually make progress. It will be slow, but not hang.
A better solution would be to aggressively cull so it only generates geometry inside the viewport, but that is considerably more complicated.
Workaround for #548