Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vello_shaders] Bring back the Bazel build hack #621

Merged
merged 2 commits into from
Jun 28, 2024
Merged

[vello_shaders] Bring back the Bazel build hack #621

merged 2 commits into from
Jun 28, 2024

Commits on Jun 28, 2024

  1. [vello_shaders] Bring back the Bazel build hack 

    Skia, an external consumer of this crate, uses Bazel rules to compile
Rust code. Due to limitations in Bazel's rust support, the
CARGO_MANIFEST_DIR environment variable isn't set properly for
nested crates as Bazel always seems to assign the workspace root
instead.

Until we figure out a better way to manage the bazel integration, this
PR reintroduces a recently-removed hack to work around this by allowing
the crate manifest path to be assigned explicitly, using a new
environment variable called `BAZEL_CRATE_MANIFEST_PATH`. This is
intended to be the absolute path to `vello_shaders/Cargo.toml` within
the bazel sandbox file system.
    @armansito
    armansito committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    cbad707 View commit details
    Browse the repository at this point in the history

  2. Rename env var to UNSTABLE_BAZEL_VELLO_SHADERS_CRATE_MANIFEST_PATH

    @armansito
    armansito committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    dce4d96 View commit details
    Browse the repository at this point in the history