Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xilem_web: Add event_target_value helper function #506

Merged
merged 3 commits into from
Aug 12, 2024
Merged

xilem_web: Add event_target_value helper function #506

merged 3 commits into from
Aug 12, 2024

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Aug 11, 2024

No description provided.

@flosse
Copy link
Contributor Author

flosse commented Aug 11, 2024

I took the opportunity to create a new util module in which all such helpers can end up.

@flosse flosse mentioned this pull request Aug 11, 2024
Open
Philipp-M
Philipp-M reviewed Aug 11, 2024
View reviewed changes
xilem_web/src/util.rs Outdated Show resolved Hide resolved
@flosse flosse force-pushed the xilem_web_add_event_target_value branch from 7e8b6c9 to c0e1277 Compare August 11, 2024 23:12
Philipp-M
Philipp-M approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. I wonder though, whether that module should be named generically util. Maybe be more explicit, like dom_util or dom_helpers or something like that?

xilem_web/src/util.rs Outdated Show resolved Hide resolved
@flosse flosse added the web label Aug 12, 2024
@flosse
Copy link
Contributor Author

flosse commented Aug 12, 2024

Thanks for the cleanup. I wonder though, whether that module should be named generically util. Maybe be more explicit, like dom_util or dom_helpers or something like that?

Good point! util is really a bit too generic.

@flosse flosse added this pull request to the merge queue Aug 12, 2024
Merged via the queue into linebender:main with commit 7d137a7 Aug 12, 2024
17 checks passed
@flosse flosse deleted the xilem_web_add_event_target_value branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philipp-M Philipp-M Philipp-M approved these changes

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flosse @Philipp-M