Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplicated logic in tracing_backend, and add some docs #530

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Reduce duplicated logic in tracing_backend, and add some docs #530

merged 2 commits into from
Aug 26, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 21, 2024

The calculation of the levels was previously duplicated for both web and native, and the WARN level was not used properly on WASM for tests.

@DJMcNab DJMcNab marked this pull request as ready for review August 21, 2024 11:06
PoignardAzur
PoignardAzur approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

masonry/src/tracing_backend.rs Show resolved Hide resolved
masonry/src/tracing_backend.rs Show resolved Hide resolved
@DJMcNab DJMcNab enabled auto-merge August 26, 2024 10:20
@DJMcNab DJMcNab added this pull request to the merge queue Aug 26, 2024
Merged via the queue into linebender:main with commit 4cb2552 Aug 26, 2024
17 checks passed
@DJMcNab DJMcNab deleted the observability branch August 26, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoignardAzur PoignardAzur PoignardAzur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJMcNab @PoignardAzur