Implement update_focus pass #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoignardAzur
force-pushed
the
implement_pass_spec_update_focus2
branch
from
25a3962
to
cc7c698
Compare
| if handled == Handled::No | ||
| && key.physical_key == PhysicalKey::Code(KeyCode::Tab) | ||
| && key.state == ElementState::Pressed | ||
| { | ||
| if !mods.shift_key() { | ||
| root.state.next_focused_widget = root.widget_from_focus_chain(true); |
There was a problem hiding this comment.
Future PR, but not a big fan of this boolean arg here, would be nicer to have Focus::Next Focus::Prev or something instead.
There was a problem hiding this comment.
Yeah, that part of the code is due for a refactor.
DJMcNab
approved these changes
Aug 26, 2024
masonry/src/event.rs
Outdated
| @@ -357,6 +349,9 @@ pub enum StatusChange { | |||
| /// | |||
| /// [`EventCtx::is_focused`]: crate::EventCtx::is_focused | |||
| FocusChanged(bool), | |||
|
|
|||
| /// Called when a widget becomes or no longer is parent of a focused widget. | |||
| HasFocusChanged(bool), | |||
There was a problem hiding this comment.
I think
ChildFocusChanged(bool),would be a better name, because HasFocusedChanged could also be read as "my focus has changed" - indeed, that's how I read it originally.
PoignardAzur
force-pushed
the
implement_pass_spec_update_focus2
branch
from
c0d1c84
to
bc1da54
Compare
PoignardAzur
force-pushed
the
implement_pass_spec_update_focus2
branch
from
d0aa999
to
d88da11
Compare
PoignardAzur
force-pushed
the
implement_pass_spec_update_focus2
branch
from
d88da11
to
ddda94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Textbox Widget tab-focusable.
This is part of the Pass Specification RFC: linebender/rfcs#7