Skip to content

Commit

Permalink
Correct an error about the MissingBlobIds. (#3059)
Browse files Browse the repository at this point in the history
The conversion of `TryFrom<RpcMessage>` for `Vec<BlobId>` was taking the input instead of the response which is wrong and makes any call to `missing_blob_ids` fail. Tests need to be added.
  • Loading branch information
MathieuDutSik authored Dec 19, 2024
1 parent 0c21189 commit 705950b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion linera-rpc/src/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl TryFrom<RpcMessage> for Vec<BlobId> {
type Error = NodeError;
fn try_from(message: RpcMessage) -> Result<Self, Self::Error> {
match message {
RpcMessage::MissingBlobIds(blob_ids) => Ok(*blob_ids),
RpcMessage::MissingBlobIdsResponse(blob_ids) => Ok(*blob_ids),
RpcMessage::Error(error) => Err(*error),
_ => Err(NodeError::UnexpectedMessage),
}
Expand Down

0 comments on commit 705950b

Please sign in to comment.