RemoteNet -> ExistingNet #2998
Merged
RemoteNet -> ExistingNet #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
12-03-remotenet_-_existingnet
branch
from
222ff53 to
0d3829b
Compare
This was referenced Dec 3, 2024
christos-h
approved these changes
Dec 3, 2024
ndr-ds
force-pushed
the
12-03-remotenet_-_existingnet
branch
from
0d3829b to
3a4b51d
Compare
ndr-ds
changed the base branch from
12-02-send_prometheus_metrics_to_grafana_cloud
to
main
ma2bd
added a commit
to ma2bd/linera-protocol
that referenced
this pull request
Dec 25, 2024
This reverts commit 909b3e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think I originally implemented this, it was originally running tests against the devnet on GCP. I don't remember what the name was then.
Regardless, now this has changed, and it actually just connects to any existing/running network that has a faucet.
I thought
RunningNetsounded weird,ExistingNetsounded better. AWithFaucetsuffix or something like that also sounded wrong. So I landed onExistingNet.Proposal
Rename all remote net things into existing net. The feature for this also had kubernetes related stuff as a dependency, even though it uses nothing kubernetes related.
So removed that.
Test Plan
CI
Release Plan