Corrections to MapView after the introduction of ValueOrBytes.
#3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Several additional suggestions were forgotten in the PR #3036
Proposal
The following corrections were made:
ValueOrBytesis marked as private.countused forSetView,CollectionView,ReentrantCollectionView,MapViewandKeyvalueStoreViewareusizewhich makes them architecture dependent. We switch to u32.FnMut(I, V)forces a clone which is not always needed. So, it was replaced byFnMut(I, Cow<'a, V>). Actually, the clone still occurs, but if someone were to want to just access the reference, it would be possible.Unfortunately, the use of the Cow complexifies the call to the
for_each_key_value.Test Plan
The CI.
Release Plan
This is a breaking change with TestNEt / DevNet as it changes the hashes values.
Links
None.