Make the chain manager a View.
#3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
reviewed
Jan 15, 2025
| """ | ||
| A GraphQL-visible map item, complete with key. | ||
| """ | ||
| type Entry_BlobId_Blob_9f0b41f3 { |
There was a problem hiding this comment.
I think it's a hash to avoid type name collisions.
deuszx
reviewed
Jan 15, 2025
| /// The owners that take over in fallback mode. | ||
| #[debug(skip_if = BTreeMap::is_empty)] | ||
| pub fallback_owners: BTreeMap<Owner, (PublicKey, u64)>, | ||
| pub fallback_owners: RegisterView<C, BTreeMap<Owner, (PublicKey, u64)>>, |
There was a problem hiding this comment.
That's a lot of mechanical work. I know it's not for this PR but it'd be nice if derive(View) wrapped all of the fields into propery *View variants.
There was a problem hiding this comment.
I don't know if that's possible in general. E.g. some but not all maps should turn into MapViews.
There was a problem hiding this comment.
sensible deafults + overrides with attributes.
There was a problem hiding this comment.
Yes, maybe. Definitely out of scope for this PR, though. 😅
deuszx
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the chain manager is serialized as a whole and stored in a
RegisterViewin the chain state view. Since it contains blobs it can be very large, and the blobs are not needed every time the chain manager is loaded.Proposal
Make the chain manager a
View, and put the blobs in aMapView.Test Plan
This doesn't change any logic, so CI should catch regressions. (In fact, it already did: #3133)
Release Plan
Links