Implement get_root_keys
to the AdminKeyValueStore
#3142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to have the feature of accessing to the list of root keys in order to have mutation function and accessing to the list of chain ids of a storage.
Fixes #3085
Proposal
The implementation causes some problems:
get_root_keys
will not be the same on different storage. If storage has been created withfn create
but no key is inserted then in ScyllaDb / DynamoDb it will not show the root_key but in RocksDb it will appear.The end result is that the
fn connect
becomes slower for RocksDb, StorageService, IndexedDb but this is I think fine as the issue of performance shows up in other operations.Test Plan
One test has been added for this feature.
Release Plan
No impact on the TestNet / DevNet. It can follow the normal release plan.
Links
None.