Improve the tests to the Views. #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvff
approved these changes
Jan 23, 2025
| type State = HashSet<i32>; | ||
|
|
||
| async fn stage_initial_changes(&mut self) -> Result<Self::State, ViewError> { | ||
| let dummy_values = [0, -1, 2, -3, 4, -5]; |
There was a problem hiding this comment.
Optional: we could create a const INITIAL_SET_VIEW_CHANGES: &[i32] = [...]; outside the impl TestView to make it easier to change it if needed in the future.
The same could also be done for other views if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently, a long-standing bug was found in the
RegisterView.Proposal
Some implementing of
TestViewwere done forSetView/QueueView.The test that detects the found problem for the
RegisterViewwas extended to all the view supportingTestView.Test Plan
Simply improve the tests.
Release Plan
Nothing relevant.
Links
None