Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Placeholder in NFT Error Messages #3186

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Fix Placeholder in NFT Error Messages #3186

merged 4 commits into from
Jan 28, 2025

Conversation

donatik27
Copy link
Contributor

Pull Request Summary

Changes Made

  1. File: examples/gen-nft/src/contract.rs

    • Old Code: .expect("NFT {token_id} not found")
    • New Code: .expect("NFT not found")
  2. File: examples/non-fungible/src/contract.rs

    • Old Code: .expect("NFT {token_id} not found")
    • New Code: .expect("NFT not found")

Reason for Changes

Improved clarity and consistency of error messages. The previous message included a placeholder {token_id} that was not replaced, leading to confusion. The new message "NFT not found" is clear and concise, aiding in debugging.

Signed-off-by: Noisy <125606576+donatik27@users.noreply.github.com>
Signed-off-by: Noisy <125606576+donatik27@users.noreply.github.com>
Signed-off-by: Noisy <125606576+donatik27@users.noreply.github.com>
Signed-off-by: Noisy <125606576+donatik27@users.noreply.github.com>
Copy link
Contributor

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@donatik27 donatik27 requested a review from afck January 28, 2025 11:28
@afck afck merged commit 2803772 into linera-io:main Jan 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants