Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npe because of clone is not thread safe in BreakpointInfo #323

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

rantianhua
Copy link
Collaborator

Closes #143

@rantianhua rantianhua added the bug label Oct 26, 2019
@rantianhua rantianhua added this to the 1.0.6 milestone Oct 26, 2019
@rantianhua rantianhua requested a review from Jacksgong October 26, 2019 07:09
@codecov-io
Copy link

Codecov Report

Merging #323 into master will decrease coverage by 0.06%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   83.73%   83.66%   -0.07%     
==========================================
  Files          74       74              
  Lines        4149     4145       -4     
  Branches      666      669       +3     
==========================================
- Hits         3474     3468       -6     
+ Misses        403      402       -1     
- Partials      272      275       +3
Impacted Files Coverage Δ
...huo/okdownload/core/breakpoint/BreakpointInfo.java 75.51% <60%> (-3.88%) ⬇️
...ulishuo.okdownload.kotlin/DownloadTaskExtension.kt 86.45% <0%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18752d...20037f5. Read the comment docs.

@Jacksgong Jacksgong merged commit fab853a into master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

空指针异常
3 participants