refactor: remove strings support from LinguiConfig.extractors

lingui · Oct 16, 2024 · 0be39d0 · 0be39d0
1 parent c027f0e
commit 0be39d0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/packages/cli/src/api/extractors/index.ts b/packages/cli/src/api/extractors/index.ts
@@ -20,16 +20,7 @@ export default async function extract(
 ): Promise<boolean> {
   const extractorsToExtract = options.extractors ?? DEFAULT_EXTRACTORS
 
-  for (let e of extractorsToExtract) {
-    let ext: ExtractorType = e
-    if (typeof e === "string") {
-      // in case of the user using require.resolve in their extractors, we require that module
-      ext = require(e)
-    }
-    if ((ext as any).default) {
-      ext = (ext as any).default
-    }
-
+  for (let ext of extractorsToExtract) {
     if (!ext.match(filename)) continue
 
     try {

diff --git a/packages/conf/src/types.ts b/packages/conf/src/types.ts
@@ -199,7 +199,7 @@ export type LinguiConfig = {
   }
   compilerBabelOptions?: any
   fallbackLocales?: FallbackLocales | false
-  extractors?: (string | ExtractorType)[]
+  extractors?: ExtractorType[]
   prevFormat?: CatalogFormat
   localeDir?: string
   format?: CatalogFormat | CatalogFormatter

diff --git a/website/docs/releases/migration-5.md b/website/docs/releases/migration-5.md
@@ -203,3 +203,5 @@ You'll need to [re-compile](/docs/ref/cli.md#compile) your messages in the new f
 ## Deprecations and Removals
 
 - Removed the deprecated `isTranslated` prop from the React `Trans` component.
+- Removed support of the module path strings in `LinguiConfig.extractors` property. Please pass extractor object directly.
+
Original file line number	Diff line number	Diff line change
Expand Up		@@ -203,3 +203,5 @@ You'll need to [re-compile](/docs/ref/cli.md#compile) your messages in the new f
		## Deprecations and Removals

		- Removed the deprecated `isTranslated` prop from the React `Trans` component.
		- Removed support of the module path strings in `LinguiConfig.extractors` property. Please pass extractor object directly.