fix(format-po-gettext): bad return during mapping with `serializePlur…

…als` (#1707)
lingui · Jun 22, 2023 · 993bd2a · 993bd2a · vercel · Jun 22, 2023
1 parent ff96df4
commit 993bd2a
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/packages/format-po-gettext/src/__snapshots__/po-gettext.test.ts.snap b/packages/format-po-gettext/src/__snapshots__/po-gettext.test.ts.snap
@@ -72,6 +72,10 @@ msgstr ""
 "Language-Team: \\n"
 "Plural-Forms: \\n"
 
+#. js-lingui-explicit-id
+msgid "static"
+msgstr "Static message"
+
 #. js-lingui-explicit-id
 #. js-lingui:pluralize_on=count
 msgid "message_with_id_and_octothorpe"
@@ -161,5 +165,18 @@ exports[`po-gettext format should convert gettext plurals to ICU plural messages
     origin: [],
     translation: ,
   },
+  static: {
+    comments: [
+      js-lingui-explicit-id,
+    ],
+    context: null,
+    extra: {
+      flags: [],
+      translatorComments: [],
+    },
+    obsolete: false,
+    origin: [],
+    translation: Static message,
+  },
 }
 `;
diff --git a/packages/format-po-gettext/src/fixtures/messages_plural.po b/packages/format-po-gettext/src/fixtures/messages_plural.po
@@ -7,6 +7,10 @@ msgstr ""
 "X-Generator: @lingui/cli\n"
 "Language: en\n"
 
+#. js-lingui-explicit-id
+msgid "static"
+msgstr "Static message"
+
 #. js-lingui:pluralize_on=someCount
 #. js-lingui-explicit-id
 msgid "message_with_id"

diff --git a/packages/format-po-gettext/src/po-gettext.test.ts b/packages/format-po-gettext/src/po-gettext.test.ts
@@ -32,6 +32,9 @@ describe("po-gettext format", () => {
 
   it("should convert ICU plural messages to gettext plurals", () => {
     const catalog: CatalogType = {
+      static: {
+        translation: "Static message",
+      },
       message_with_id_and_octothorpe: {
         message: "{count, plural, one {Singular} other {Number is #}}",
         translation: "{count, plural, one {Singular} other {Number is #}}",

diff --git a/packages/format-po-gettext/src/po-gettext.ts b/packages/format-po-gettext/src/po-gettext.ts
@@ -54,7 +54,7 @@ function serializePlurals(
   const icuMessage = message.message
 
   if (!icuMessage) {
-    return
+    return item
   }
 
   const _simplifiedMessage = icuMessage.replace(LINE_ENDINGS, " ")