fix(macro types): mark other as required for ChoiceOptions (#1527)

lingui · Mar 17, 2023 · c4b700d · c4b700d
1 parent db6e497
commit c4b700d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/macro/__typetests__/index.test-d.tsx b/packages/macro/__typetests__/index.test-d.tsx
@@ -143,6 +143,9 @@ expectType<string>(
   })
 )
 
+// @ts-expect-error: other is required
+expectType<string>(plural(5, { one: "test" }))
+
 ///////////////////
 //// Select Ordinal
 ///////////////////

diff --git a/packages/macro/index.d.ts b/packages/macro/index.d.ts
@@ -13,7 +13,7 @@ export type ChoiceOptions = {
   many?: string
 
   /** Catch-all option */
-  other?: string
+  other: string
   /** Exact match form, corresponds to =N rule */
   [digit: `${number}`]: string
 }