fix: formatters exceptions throw error (#889)

lingui · Nov 26, 2020 · d6b774c · d6b774c · vercel · Nov 26, 2020
1 parent 3d54b4d
commit d6b774c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/packages/cli/src/api/formats/csv.ts b/packages/cli/src/api/formats/csv.ts
@@ -45,8 +45,7 @@ const csv: CatalogFormatter = {
     try {
       return deserialize(raw)
     } catch (e) {
-      console.error(`Cannot read ${filename}: ${e.message}`)
-      return null
+      throw new Error(`Cannot read ${filename}: ${e.message}`)
     }
   },
 }

diff --git a/packages/cli/src/api/formats/lingui.ts b/packages/cli/src/api/formats/lingui.ts
@@ -30,8 +30,7 @@ const lingui: CatalogFormatter = {
     try {
       return JSON.parse(raw)
     } catch (e) {
-      console.error(`Cannot read ${filename}: ${e.message}`)
-      return null
+      throw new Error(`Cannot read ${filename}: ${e.message}`)
     }
   },
 }

diff --git a/packages/cli/src/api/formats/minimal.ts b/packages/cli/src/api/formats/minimal.ts
@@ -33,8 +33,7 @@ const minimal: CatalogFormatter = {
       const rawCatalog: Record<string, string> = JSON.parse(raw)
       return deserialize(rawCatalog)
     } catch (e) {
-      console.error(`Cannot read ${filename}: ${e.message}`)
-      return null
+      throw new Error(`Cannot read ${filename}: ${e.message}`)
     }
   },
 }

diff --git a/packages/cli/src/api/formats/po.ts b/packages/cli/src/api/formats/po.ts
@@ -62,6 +62,9 @@ const deserialize: (item: Object) => Object = R.map(
 )
 
 type POItem = InstanceType<typeof PO.Item>
+type PoFormatter = {
+  parse: (raw: string) => Object
+}
 
 const validateItems = R.forEach<POItem>((item) => {
   if (R.length(getTranslations(item)) > 1) {
@@ -74,7 +77,7 @@ const validateItems = R.forEach<POItem>((item) => {
 
 const indexItems = R.indexBy(getMessageKey)
 
-const po: CatalogFormatter = {
+const po: CatalogFormatter & PoFormatter = {
   catalogExtension: ".po",
 
   write(filename, catalog, options) {
@@ -99,7 +102,6 @@ const po: CatalogFormatter = {
     return this.parse(raw)
   },
 
-  // @ts-ignore
   parse(raw) {
     const po = PO.parse(raw)
     validateItems(po.items)