Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to disable lineNumbers #1007

Merged
merged 1 commit into from
Mar 19, 2021
Merged

feat: allow to disable lineNumbers #1007

merged 1 commit into from
Mar 19, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Mar 18, 2021

Will close #805

@vercel
Copy link

vercel bot commented Mar 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/2et1nVAVGDBbEgDHJ38Yq7w3vzCn
✅ Preview: https://js-lingui-git-feat-linenumbers-optional-lingui-js.vercel.app

@github-actions
Copy link

github-actions bot commented Mar 18, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.72 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1007 (1e2f9e5) into main (d66741d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
+ Coverage   83.24%   83.34%   +0.10%     
==========================================
  Files          53       53              
  Lines        1611     1621      +10     
  Branches      432      435       +3     
==========================================
+ Hits         1341     1351      +10     
  Misses        157      157              
  Partials      113      113              
Impacted Files Coverage Δ
packages/cli/src/api/catalog.ts 81.56% <ø> (ø)
packages/conf/src/index.ts 80.51% <ø> (ø)
packages/cli/src/api/formats/lingui.ts 94.11% <100.00%> (+3.20%) ⬆️
packages/cli/src/api/formats/po.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6baa1b...1e2f9e5. Read the comment docs.

@semoal semoal force-pushed the feat-lineNumbers-optional branch from e1d2315 to 1e2f9e5 Compare March 18, 2021 16:37
@semoal semoal merged commit fe67e0f into main Mar 19, 2021
@semoal semoal deleted the feat-lineNumbers-optional branch March 19, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option for formatOptions - origins - lineNumbers: true / false
1 participant