refactor(macro): make code strongly typed

[timofei-iatsenko]

No logic changes. Added types wherever possible and fix issues. Also added few more tests for "black zones".

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	Jan 10, 2023 at 3:51PM (UTC)

[timofei-iatsenko]

@andrii-bodnar FYI

[codecov]

Codecov Report

Base: 82.60% // Head: 82.99% // Increases project coverage by +0.39% 🎉

Coverage data is based on head (82983a6) compared to base (ad9b735).
Patch coverage: 93.75% of modified lines in pull request are covered.

❗ Current head 82983a6 differs from pull request most recent head e383dba. Consider uploading reports for the commit e383dba to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   82.60%   82.99%   +0.39%     
==========================================
  Files          56       66      +10     
  Lines        1799     1805       +6     
  Branches      506      505       -1     
==========================================
+ Hits         1486     1498      +12     
+ Misses        183      178       -5     
+ Partials      130      129       -1     

Impacted Files	Coverage Δ
packages/macro/src/utils.ts	100.00% <ø> (ø)
packages/macro/src/macroJsx.ts	90.34% <84.84%> (-0.96%)	⬇️
packages/macro/src/icu.ts	94.87% <94.59%> (-0.26%)	⬇️
packages/macro/src/macroJs.ts	97.87% <97.61%> (+5.20%)	⬆️
packages/macro/src/index.ts	83.60% <100.00%> (ø)
packages/macro/test/js-arg.ts	100.00% <100.00%> (ø)
packages/macro/test/js-defineMessage.ts	100.00% <100.00%> (ø)
packages/macro/test/js-plural.ts	100.00% <100.00%> (ø)
packages/macro/test/js-select.ts	100.00% <100.00%> (ø)
packages/macro/test/js-selectOrdinal.ts	100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Martin005]

Thank you for your pull request!

I have made some suggestions and commented one question.

From the 3 empty lines and no spaces around value names in import's, I believe you are not running Prettier. Please set it up and run it on this PR.

As we have merged your PR #1329 into main, please merge main into your branch as that PR made some changes to the packages/macro/src/index.ts file.

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/cjs/core.production.min.js	2.9 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js	798 B (0%)
./packages/react/build/cjs/react.production.min.js	4.91 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js	92.08 KB (0%)

[timofei-iatsenko]

messed up things with rebase, looking why commits from main is showed as my

[timofei-iatsenko]

Done

[andrii-bodnar]

@thekip @Martin005 is this PR ready to merge?

[timofei-iatsenko]

Nothing to add from my side