-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conf): proper typings for LinguiConfig['runtimeConfigModule'] #1329
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportBase: 82.60% // Head: 82.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 56 56
Lines 1799 1799
Branches 506 506
=======================================
Hits 1486 1486
Misses 183 183
Partials 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thekip Please rename the what
parameter to identifier
2858b4a
to
17932d4
Compare
Done |
size-limit report 📦
|
https://lingui.js.org/ref/conf.html#id12
runtimeConfigModule should accepts or tuple or object with properties, this PR fixing typings to reflect this