Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conf): proper typings for LinguiConfig['runtimeConfigModule'] #1329

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

https://lingui.js.org/ref/conf.html#id12

runtimeConfigModule should accepts or tuple or object with properties, this PR fixing typings to reflect this

@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
js-lingui ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 1:32PM (UTC)

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 82.60% // Head: 82.60% // No change to project coverage 👍

Coverage data is based on head (2858b4a) compared to base (2f500a9).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head 2858b4a differs from pull request most recent head 17932d4. Consider uploading reports for the commit 17932d4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files          56       56           
  Lines        1799     1799           
  Branches      506      506           
=======================================
  Hits         1486     1486           
  Misses        183      183           
  Partials      130      130           
Impacted Files Coverage Δ
packages/macro/src/index.ts 83.60% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Martin005 Martin005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thekip Please rename the what parameter to identifier

@timofei-iatsenko
Copy link
Collaborator Author

Done

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.9 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.91 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 92.08 KB (0%)

@Martin005 Martin005 changed the title fix(conf) proper typings for LinguiConfig['runtimeConfigModule'] fix(conf): proper typings for LinguiConfig['runtimeConfigModule'] Jan 10, 2023
@andrii-bodnar andrii-bodnar merged commit 389bb85 into lingui:main Jan 10, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/conf-typings branch January 10, 2023 14:56
timofei-iatsenko added a commit to timofei-iatsenko/js-lingui that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants