-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(format-po-gettext): bad return during mapping with serializePlurals
#1707
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 75.82% 76.01% +0.19%
==========================================
Files 79 79
Lines 2039 2039
Branches 524 524
==========================================
+ Hits 1546 1550 +4
+ Misses 378 376 -2
+ Partials 115 113 -2
☔ View full report in Codecov by Sentry. |
Thanks for tackling this. Please create a test case covering this. |
@thekip Done. |
@stovmascript big thanks! |
Description
In v4 this formatter can return
undefined
when passing a non-plural message to theserializePlurals
function, which will throw later when serializing the PO file. The original item should be returned instead.Types of changes
Fixes # (issue)
Checklist