fix: allow parentheses in catalog pathnames #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jozefmery
changed the title
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
=======================================
Coverage ? 76.39%
=======================================
Files ? 81
Lines ? 2072
Branches ? 529
=======================================
Hits ? 1583
Misses ? 377
Partials ? 112 ☔ View full report in Codecov by Sentry. |
timofei-iatsenko
approved these changes
Dec 18, 2023
andrii-bodnar
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Escape parentheses in the pathname pattern according to the following issue: micromatch/micromatch#123
The solution uses the simplest possible approach: the String#replace method. I considered the
escape-string-regexppackage, but it seems thatparenthesesare the only problematic characters.Types of changes
Fixes #1819
Checklist
yarn test, butyarn release:testfails with the following message:The filename, directory name, or volume label syntax is incorrect. command not found: test:tsd. I believe this is unrelated to my changes and may warrant its own issue.)