Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to extract concatenated comments #1152

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

tannerlyons
Copy link
Contributor

Hello! Once again thanks for lingui. We're using it more and more at Smartsheet.

I ran into this after my translation comments were quite verbose. I wanted to break them into multiple lines and concatenate them:

...
comment: "first long line" +
"second long line",
...

1 question, if you'd like to go forward with this PR: should this concatenation extraction be applied to the id as well?

@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/HqTFub1jzE4fSvFbY3rJvJJ96aR7
✅ Preview: https://js-lingui-git-fork-tannerlyons-main-lingui-js.vercel.app

@tannerlyons tannerlyons changed the title add the ability to extract concatenated comments feat: add the ability to extract concatenated comments Oct 26, 2021
@tannerlyons
Copy link
Contributor Author

Howdy, I don't understand the following error in the pipeline as it relates to my changes: https://github.com/lingui/js-lingui/runs/4014369422?check_suite_focus=true#step:3:40

Any advice on how I can go about solving this?

...
$ node ./scripts/build/
...
- @lingui/react.development.js (node_dev)
✖ @lingui/react.development.js (node_dev)
-- PLUGIN_ERROR (rpt2) --
packages/react/src/I18nProvider.tsx:2:22 - error TS6059: File '/home/runner/work/js-lingui/js-lingui/packages/core/src/index.ts' is not under 'rootDir' '/home/runner/work/js-lingui/js-lingui/packages/react/src'. 'rootDir' is expected to contain all source files.

2 import { I18n } from "@lingui/core"
                       ~~~~~~~~~~~~~~

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@semoal
Copy link
Contributor

semoal commented Nov 2, 2021

Is not your problem Tanner don't worry, the pr looks good to me mate. Will fix the CI asap

@semoal semoal merged commit 0e553cf into lingui:main Nov 26, 2021
@semoal
Copy link
Contributor

semoal commented Nov 26, 2021

Thanks mate, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants