refactor(macro): more accurate typings for macro + testing #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Martin005 @andrii-bodnar Guys i need your reaction & feedback |
|
@thekip |
|
We'd like to postpone any breaking changes for a while, but your suggestion is fair |
timofei-iatsenko
force-pushed
the
chore/tsd-linting
branch
from
3a065a2 to
35b810b
Compare
size-limit report 📦
|
timofei-iatsenko
force-pushed
the
chore/tsd-linting
branch
from
35b810b to
ac85977
Compare
timofei-iatsenko
changed the title
timofei-iatsenko
changed the title
timofei-iatsenko
force-pushed
the
chore/tsd-linting
branch
from
ac85977 to
5fbb661
Compare
Codecov ReportBase: 69.49% // Head: 69.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #1340 +/- ##
==========================================
+ Coverage 69.49% 69.79% +0.30%
==========================================
Files 77 76 -1
Lines 2016 1980 -36
Branches 542 541 -1
==========================================
- Hits 1401 1382 -19
+ Misses 496 479 -17
Partials 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Martin005
reviewed
Feb 14, 2023
timofei-iatsenko
force-pushed
the
chore/tsd-linting
branch
from
b98052f to
2fa6166
Compare
Co-authored-by: Martin Chrástek <chrastek12@gmail.com>
timofei-iatsenko
force-pushed
the
chore/tsd-linting
branch
from
2fa6166 to
b29ffe5
Compare
Martin005
approved these changes
Feb 14, 2023
andrii-bodnar
approved these changes
Feb 14, 2023
This was
linked to
issues
Feb 14, 2023
Martin005
added a commit
that referenced
this pull request
Feb 14, 2023
* refactor(macro): more accurate typings for macro + testing * Apply suggestions from code review Co-authored-by: Martin Chrástek <chrastek12@gmail.com>
Martin005
added a commit
that referenced
this pull request
Feb 14, 2023
* refactor(macro): more accurate typings for macro + testing * Apply suggestions from code review Co-authored-by: Martin Chrástek <chrastek12@gmail.com>
andrii-bodnar
pushed a commit
that referenced
this pull request
Feb 20, 2023
* refactor(macro): more accurate typings for macro + testing * Apply suggestions from code review Co-authored-by: Martin Chrástek <chrastek12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one without explicit braking changes. Separating js / jsx macro typings would do in next iterations.
Changing public typings would definitely affect some users because they become stricter and would catch more misusages and possible errors.
Fixes:
#1324
#1323
#1288