-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conf): proper typescript cosmiconfig loader #1386
fix(conf): proper typescript cosmiconfig loader #1386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
mockFs({ | ||
".linguirc": JSON.stringify({ | ||
locales: ["en-US"], | ||
fallbackLocale: "en", | ||
}), | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mockFs is actually very dangerous because it breaks resolution of files in underlying libraries. typescript-comiconfig is not an exclusion. It didn't work with mockFs, so I removed it in favour of real file in FS.
Codecov ReportBase: 82.60% // Head: 82.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
+ Coverage 82.60% 82.63% +0.02%
==========================================
Files 56 66 +10
Lines 1799 1756 -43
Branches 506 483 -23
==========================================
- Hits 1486 1451 -35
+ Misses 183 177 -6
+ Partials 130 128 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fixes: #1295