Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript #1395

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Here we go again

Types of changes

  • Chore task
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 6:22PM (UTC)

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 2.89 KB (0%)
./packages/detect-locale/build/esm/index.js 804 B (0%)
./packages/react/build/esm/index.js 2.61 KB (0%)
./packages/remote-loader/build/esm/index.js 7.36 KB (0%)

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 82.60% // Head: 82.66% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (bae083c) compared to base (ad9b735).
Patch coverage: 90.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   82.60%   82.66%   +0.05%     
==========================================
  Files          56       66      +10     
  Lines        1799     1759      -40     
  Branches      506      487      -19     
==========================================
- Hits         1486     1454      -32     
+ Misses        183      177       -6     
+ Partials      130      128       -2     
Impacted Files Coverage Δ
packages/cli/src/api/formats/index.ts 60.00% <ø> (ø)
packages/conf/src/index.ts 85.13% <ø> (-0.95%) ⬇️
packages/core/src/formats.ts 84.37% <ø> (ø)
packages/core/src/index.ts 100.00% <ø> (ø)
packages/macro/src/utils.ts 100.00% <ø> (ø)
packages/react/src/Trans.tsx 80.64% <ø> (ø)
packages/remote-loader/src/index.ts 66.66% <ø> (ø)
packages/remote-loader/src/browserCompiler.ts 40.00% <40.00%> (-24.87%) ⬇️
packages/cli/src/api/detect.ts 57.89% <66.66%> (-6.82%) ⬇️
packages/core/src/context.ts 80.00% <77.77%> (+0.37%) ⬆️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar
Copy link
Contributor

There was some issue as a reason why it was reverted previously. @Martin005, could you please briefly describe this issue?

@Martin005
Copy link
Contributor

Martin005 commented Feb 3, 2023

@andrii-bodnar Yes, when testing previously, I was getting the following error when running the react-scripts start command in our current Create React App example:

TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'

When testing now, the error doesn't appear anymore.

I think that when testing previously, yarn used newer version of Typescript which is incompatible with the current version 4.0.0 of react-scripts as mentioned nere: facebook/create-react-app#10110

@andrii-bodnar andrii-bodnar merged commit 6a90cb9 into lingui:main Feb 3, 2023
@timofei-iatsenko timofei-iatsenko deleted the chore/update-typescript branch February 3, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants