Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update LinguiConfig typings, add tsd test #1485

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Mar 7, 2023

Update LinguiConfig typings, clarify which properties are required and which are not.
Change running TSD test to jest-runner.
Change shape of Extractor type, to make it more future-proof. (it already had a breaking change in v4)

BREAKING CHANGES:

Shape of ExtractorType was slightly changed.

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1480

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 11:57AM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.72 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review March 7, 2023 11:49
BREAKING CHANGES:

Shape of `ExtractorType` was slightly changed.
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (637f5cf) 73.98% compared to head (d2c23f2) 74.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1485      +/-   ##
==========================================
+ Coverage   73.98%   74.02%   +0.03%     
==========================================
  Files          68       68              
  Lines        1903     1902       -1     
  Branches      501      501              
==========================================
  Hits         1408     1408              
+ Misses        379      378       -1     
  Partials      116      116              
Impacted Files Coverage Δ
packages/conf/src/makeConfig.ts 100.00% <ø> (+5.26%) ⬆️
packages/cli/src/api/extractors/babel.ts 93.10% <100.00%> (ø)
packages/cli/src/api/extractors/index.ts 64.70% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit 839f0b7 into lingui:next Mar 8, 2023
@timofei-iatsenko timofei-iatsenko deleted the various-conf-fixes branch March 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinguiConfig type from '@lingui/conf' has incorrect required props
2 participants