refactor(core): use Intl.PluralRules #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
commented
Mar 7, 2023
timofei-iatsenko
force-pushed
the
use-intl-plural-rules
branch
from
1f864c2 to
fc638f5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1486 +/- ##
==========================================
- Coverage 74.02% 73.92% -0.11%
==========================================
Files 68 67 -1
Lines 1902 1875 -27
Branches 501 489 -12
==========================================
- Hits 1408 1386 -22
- Misses 378 383 +5
+ Partials 116 106 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timofei-iatsenko
force-pushed
the
use-intl-plural-rules
branch
from
fc638f5 to
13a7a3e
Compare
|
@thekip thank you, looks good to me. Could you please add a corresponding note about this change in the v4 migration guide? I'd like to release it today within the |
- always provide fallback to english. This is useful for cases with pseudo localization - allow to pass locales[] for all formatters, this unlocks possibility to override fallback for some locales
timofei-iatsenko
force-pushed
the
use-intl-plural-rules
branch
from
13a7a3e to
93a2a5e
Compare
|
@andrii-bodnar I added 2 new commits. One with a note and another with additional refactoring. Please check description of that commit. |
timofei-iatsenko
force-pushed
the
use-intl-plural-rules
branch
from
93a2a5e to
8a64cf8
Compare
andrii-bodnar
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1446