feat(extractor): support TS experimental decorators #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // dynamicImport | ||
| import('./guy').then(a) | ||
| import("./guy").then(a) |
There was a problem hiding this comment.
Prettier change the formatting on save / before commit actions even if this files added as ignored 😬
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
force-pushed
the
feature-support-ts-experimental-decorators
branch
from
9a7ca31 to
9fbd123
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1517 +/- ##
==========================================
+ Coverage 74.12% 74.16% +0.04%
==========================================
Files 67 67
Lines 1863 1866 +3
Branches 490 490
==========================================
+ Hits 1381 1384 +3
Misses 380 380
Partials 102 102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Mar 16, 2023
capaj
reviewed
Mar 16, 2023
Comment on lines
+5
to
+6
| // supports typescript legacy decorator on parameters | ||
| constructor(@Decorator() param) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Babel parser since 7.21.0 understand both before and after export decorators, so
decoratorsBeforeExportparser option is not needed.But for typescript's legacy decorators which could be applied for class method parameters we need to use different parser plugin.
The problem is that these two plugins are not compatible with each other, so user should choose one. Use standardized decorators in theirs typescript code (default behaviour) or experimental (legacy). For JS code standardized decorators are always applied.
This is more or less aligned with upcoming typescript 5 release https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#decorators
Types of changes
Fixes #1512
Checklist