-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-loader): support json catalogs. Improve coverage #1525
fix(webpack-loader): support json catalogs. Improve coverage #1525
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
943eeb4
to
75a312c
Compare
size-limit report 📦
|
75a312c
to
7e8259d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Ready. Windows WF failed yesterday because of no binary for the latest node was precompiled. It seems today they fixed it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1525 +/- ##
==========================================
+ Coverage 75.75% 75.98% +0.23%
==========================================
Files 79 79
Lines 1980 1970 -10
Branches 516 517 +1
==========================================
- Hits 1500 1497 -3
+ Misses 360 355 -5
+ Partials 120 118 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
49a4019
to
8658981
Compare
Description
Using json catalogs with webpack loader was broken. Fixed that and added that case to a tests
Details overview:
json
content type for that module. Despite the fact the loader may return a different type of file. There is no way (except of dirty hacks involving executing private internals of webpack) to tell to webpack that this loader will perform a transformation fromjson
tojs
. So intstead i just compile catalog in json format and feed it to webpack.Types of changes
Fixes # (issue)
Checklist