Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin): support different extensions for catalogs. Improve coverage #1526

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Mar 16, 2023

Description

Part of custom formatters ongoing work. Prepare loaders to works with not only *.po.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 10:01AM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 16, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.57 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.67 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@timofei-iatsenko

This comment was marked as outdated.

@timofei-iatsenko
Copy link
Collaborator Author

@andrii-bodnar please stop windows WFs here. Looks like they have no time limit and already executing for couple hours 😮

@andrii-bodnar
Copy link
Contributor

@thekip stopped. It was running for 3 hours 😬

I will look into time limiting it tomottow

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.84 ⚠️

Comparison is base (4f1d30e) 75.75% compared to head (ab3489c) 74.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1526      +/-   ##
==========================================
- Coverage   75.75%   74.92%   -0.84%     
==========================================
  Files          79       79              
  Lines        1980     1974       -6     
  Branches      516      517       +1     
==========================================
- Hits         1500     1479      -21     
- Misses        360      375      +15     
  Partials      120      120              
Impacted Files Coverage Δ
packages/vite-plugin/src/index.ts 0.00% <0.00%> (-69.24%) ⬇️
packages/vite-plugin/test/default-vite.config.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko timofei-iatsenko force-pushed the feat/vite-plugin-extensions branch from 7c5472a to e5bc725 Compare March 17, 2023 09:01
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review March 17, 2023 09:11
packages/vite-plugin/README.md Outdated Show resolved Hide resolved
website/docs/ref/vite-plugin.md Outdated Show resolved Hide resolved
Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
@timofei-iatsenko timofei-iatsenko changed the title feat(vite): support different extensions for catalogs. Improve coverage feat(vite-plugin): support different extensions for catalogs. Improve coverage Mar 17, 2023
@andrii-bodnar andrii-bodnar merged commit 8e94c47 into lingui:next Mar 17, 2023
@usercao
Copy link

usercao commented Mar 27, 2023

Pleasant update, praising your work.

@timofei-iatsenko timofei-iatsenko deleted the feat/vite-plugin-extensions branch March 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants