Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macro types): mark other as required for ChoiceOptions #1527

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix(macro types): mark other as required for ChoiceOptions #1527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c255e0
fix(macro types): mark `other` as required for ChoiceOptions
taozhou-glean Mar 16, 2023
ace89d4
Add type tests
taozhou-glean Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/macro/__typetests__/index.test-d.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ expectType<string>(
})
)

// @ts-expect-error: other is required
expectType<string>(plural(5, { one: "test" }))

///////////////////
//// Select Ordinal
///////////////////
Expand Down
2 changes: 1 addition & 1 deletion packages/macro/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type ChoiceOptions = {
many?: string

/** Catch-all option */
other?: string
other: string
/** Exact match form, corresponds to =N rule */
[digit: `${number}`]: string
}
Expand Down