Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formatter-po): ability to disable lingui-id, make it false by default #1540

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Mar 21, 2023

Description

Newly introduced js-lingui-id creates a lot of noise in po files and may cause merge conflicts. This PR makes it optional and disabled by default. All tests snapshots got updated.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 9:36AM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.57 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.59 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@andrii-bodnar andrii-bodnar merged commit 10633f3 into lingui:next Mar 21, 2023
@timofei-iatsenko timofei-iatsenko deleted the disable-lingui-id-in-po branch March 21, 2023 09:52
@bravo-kernel
Copy link
Contributor

bravo-kernel commented Mar 21, 2023

Are there any benefits to enabling js-lingui-id for simple end-users that we would otherwise miss out on?

@timofei-iatsenko
Copy link
Collaborator Author

No. Maybe for some debugging purpose only.

@bravo-kernel
Copy link
Contributor

Perfect, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants