Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): extend formatters api with source lang #1542

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

Pass sourcelang to the formatters

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 1:11PM (UTC)

@timofei-iatsenko timofei-iatsenko changed the title ref(cli): extend formatters api with source lang refactor(cli): extend formatters api with source lang Mar 21, 2023
@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.61 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.59 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (3659dec) 75.34% compared to head (af4146d) 75.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1542   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          78       78           
  Lines        1971     1971           
  Branches      515      515           
=======================================
  Hits         1485     1485           
  Misses        375      375           
  Partials      111      111           
Impacted Files Coverage Δ
packages/cli/src/api/formats/formatterWrapper.ts 100.00% <ø> (ø)
...rc/extract-experimental/getExperimentalCatalogs.ts 100.00% <ø> (ø)
packages/cli/src/lingui-compile.ts 29.62% <0.00%> (ø)
packages/cli/src/lingui-extract-experimental.ts 60.60% <ø> (ø)
packages/cli/src/tests.ts 77.77% <ø> (ø)
packages/cli/src/api/catalog/getCatalogs.ts 95.74% <100.00%> (ø)
packages/cli/src/api/formats/index.ts 42.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit 813b7f4 into lingui:next Mar 21, 2023
@timofei-iatsenko timofei-iatsenko deleted the source-lang-to-formatters branch March 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants