-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new package with vue extractor #1578
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
e743e1d
to
ca90a41
Compare
fdc5e9a
to
b2b6b59
Compare
bc10f9d
to
f1ec5c1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1578 +/- ##
==========================================
+ Coverage 75.40% 75.53% +0.13%
==========================================
Files 76 77 +1
Lines 1980 1991 +11
Branches 518 520 +2
==========================================
+ Hits 1493 1504 +11
+ Misses 375 374 -1
- Partials 112 113 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
f20d76a
to
3089551
Compare
3089551
to
cfe9b88
Compare
cfe9b88
to
8a8f3d5
Compare
8a8f3d5
to
debbcc3
Compare
debbcc3
to
100105b
Compare
b04cd97
to
1f15413
Compare
@andrii-bodnar website page has been added now |
1f15413
to
7b7f231
Compare
7b7f231
to
e9a287b
Compare
@j4hr3n please address my latest comments and then this PR will be merged |
e9a287b
to
f1915c4
Compare
@andrii-bodnar done |
f1915c4
to
74dee23
Compare
I managed to make this work on a poorly-maintained Vue 2.6 project by fixing two things : adding const babel = require('@lingui/cli/api/extractors/babel').default; and handling the case of an SFC with no const compiledTemplate = descriptor.template && compilerSfc.compileTemplate({
source: descriptor.template.content,
filename,
inMap: descriptor.template.map,
id: filename
}); |
@Touffy Would you like to create a PR with these changes and fixture for the case where template is not presented? |
Sure. |
I don't know how to change how the |
you don't have to, the If you consuming from pure ESM or using transpiling with interop and etc. In a newer code i'm avoiding So if with additional |
Description
Types of changes
Fixes # (issue)
Checklist