Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(macro)!: remove arg macro #1581

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 8:58am

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.56 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (bdbd6cf) 75.74% compared to head (1d74e1b) 75.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1581      +/-   ##
==========================================
- Coverage   75.74%   75.63%   -0.12%     
==========================================
  Files          77       76       -1     
  Lines        1987     1982       -5     
  Branches      522      520       -2     
==========================================
- Hits         1505     1499       -6     
  Misses        371      371              
- Partials      111      112       +1     
Impacted Files Coverage Δ
packages/macro/src/macroJs.ts 95.33% <ø> (-0.13%) ⬇️
packages/macro/test/js-defineMessage.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar linked an issue Apr 5, 2023 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit defda77 into lingui:next Apr 5, 2023
@timofei-iatsenko timofei-iatsenko deleted the refactor/remove-arg-macro branch April 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro docs lack examples of arg() macro
2 participants