Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support array of react components in values #1593

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

taozhou-glean
Copy link
Contributor

Description

fix #1592

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1592

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 6:12am

@taozhou-glean taozhou-glean changed the base branch from main to next April 13, 2023 06:04
@taozhou-glean taozhou-glean changed the title Tao fix 2 fix: support array of react components in values Apr 13, 2023
@github-actions
Copy link

github-actions bot commented Apr 13, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.56 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (10a254d) 75.30% compared to head (a498e39) 75.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1593      +/-   ##
==========================================
+ Coverage   75.30%   75.35%   +0.04%     
==========================================
  Files          76       76              
  Lines        1976     1980       +4     
  Branches      516      518       +2     
==========================================
+ Hits         1488     1492       +4     
  Misses        375      375              
  Partials      113      113              
Impacted Files Coverage Δ
packages/react/src/Trans.tsx 82.35% <100.00%> (+1.10%) ⬆️
packages/react/src/format.ts 96.55% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taozhou-glean thank you!

@andrii-bodnar andrii-bodnar merged commit d1f1a4b into lingui:next Apr 13, 2023
@andrii-bodnar
Copy link
Contributor

@taozhou-glean just noticed this:

warning

could you please check?

@taozhou-glean
Copy link
Contributor Author

@taozhou-glean just noticed this:

warning

could you please check?

fix in #1595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4 next] can not interpolate variables as array of react components
3 participants