Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(po-format): add explicitIdAsDefault for po-format for easier migration #1672

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented May 25, 2023

Description

As was raised few time on github issues and discord, people experiencing troubles while migrating catalogs with explicit IDs. This PR adds documentation as well as a new option for po-format which is aimed to make migration smoother.

Related: #1667

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 4:23pm

@timofei-iatsenko timofei-iatsenko force-pushed the feature/excplicit-id-migration branch from c78c7dc to 7d2c58f Compare May 25, 2023 15:11
@github-actions
Copy link

github-actions bot commented May 25, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@timofei-iatsenko timofei-iatsenko changed the title feature(po-format): add explicitIdAsDefault for po-format for easier migration feat(po-format): add explicitIdAsDefault for po-format for easier migration May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.02 🎉

Comparison is base (f06cdf5) 75.70% compared to head (d0aeb7b) 75.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
+ Coverage   75.70%   75.72%   +0.02%     
==========================================
  Files          79       79              
  Lines        2033     2039       +6     
  Branches      520      524       +4     
==========================================
+ Hits         1539     1544       +5     
  Misses        379      379              
- Partials      115      116       +1     
Impacted Files Coverage Δ
packages/format-po/src/po.ts 92.64% <90.00%> (-0.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit 3303228 into lingui:main May 26, 2023
@timofei-iatsenko timofei-iatsenko deleted the feature/excplicit-id-migration branch May 26, 2023 09:47
@andrii-bodnar andrii-bodnar linked an issue May 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration note for custom message IDs in v4
2 participants