chore(build): update unbuild, and expose mts / mjs typings #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
force-pushed
the
chore/update-unbuild
branch
from
c15669a
to
86bd477
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 75.95% 75.95%
=======================================
Files 81 81
Lines 2063 2063
Branches 529 529
=======================================
Hits 1567 1567
Misses 383 383
Partials 113 113 ☔ View full report in Codecov by Sentry. |
|
It seems size testing worklflow works incorrect. It doesn't compare files from current PR instead it compare files from main branch. The size increase was due to this PR #1746 but size-limit didn't catch that there. Instead it complains in every consequent PR made after that. |
andrii-bodnar
approved these changes
Aug 29, 2023
|
😍 |
|
@thekip will this move forward soon, or is it blocked by the size test? |
timofei-iatsenko
force-pushed
the
chore/update-unbuild
branch
from
86bd477
to
95fe9d7
Compare
|
@sentience available in v4.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related #1750 (comment)
Types of changes
Fixes # (issue)
Checklist