Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the minimum required node version to 20 #2037

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ["16", "18", "19", "20"]
node: ["20", "22"]
os: [ubuntu-latest, windows-latest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
uses: actions/setup-node@v4
with:
always-auth: true
node-version: 16
node-version: 20
cache: 'yarn'

- name: Install dependencies if needed
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"postinstall": "yarn stub:all"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"@babel/preset-env": "^7.20.2",
Expand All @@ -46,7 +46,7 @@
"@tsd/typescript": "^4.9.5",
"@types/jest": "^29.4.0",
"@types/mock-fs": "^4.13.1",
"@types/node": "16.18.13",
"@types/node": "20.14.8",
"@types/ramda": "^0.27.23",
"@typescript-eslint/eslint-plugin": "^5.50.0",
"@typescript-eslint/parser": "^5.50.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-extract-messages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"@babel/core": "^7.21.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-lingui-macro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"dependencies": {
"@babel/core": "^7.20.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"build": "rimraf ./dist && tsc -p tsconfig.build.json"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/lingui-compile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ if (require.main === module) {
return previousRun
}

let debounceTimer: NodeJS.Timer
let debounceTimer: NodeJS.Timeout

const dispatchCompile = () => {
// Skip debouncing if not enabled
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/lingui-extract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ if (require.main === module) {
}

const changedPaths = new Set<string>()
let debounceTimer: NodeJS.Timer
let debounceTimer: NodeJS.Timeout
let previousExtract = Promise.resolve(true)
const dispatchExtract = (filePath?: string[]) => {
// Skip debouncing if not enabled but still chain them so no racing issue
Expand Down
2 changes: 1 addition & 1 deletion packages/conf/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"module": "dist/index.mjs",
"types": "dist/index.d.ts",
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"scripts": {
"build": "rimraf ./dist && unbuild",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion packages/detect-locale/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion packages/extractor-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"stub": "unbuild --stub"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/format-csv/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/format-json/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/format-po-gettext/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/format-po/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-mocks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=10.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/loader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion packages/macro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion packages/message-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"README.md",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion packages/remote-loader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"url": "https://github.com/lingui/js-lingui/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"files": [
"LICENSE",
Expand Down
2 changes: 1 addition & 1 deletion website/docs/releases/migration-5.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Node.js version

TBD
The minimum required version of Node.js is **20**.

## React and JS Macros were split to separate packages

Expand Down
19 changes: 14 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4945,10 +4945,12 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:16.18.13":
version: 16.18.13
resolution: "@types/node@npm:16.18.13"
checksum: c284f97a0630d65887be0e0d7ef8e5e5022eb4916ffae142db07f22dad565a80f17b6a84f21b4521c707f642540430710a8aa5930a2cf2bcbecde0a476ff9c02
"@types/node@npm:20.14.8":
version: 20.14.8
resolution: "@types/node@npm:20.14.8"
dependencies:
undici-types: ~5.26.4
checksum: a9128840005d4a0aba68826e22ac0fdd86bb9073f1d274217d3509b52f969d1aab83415c85a8461259f33cf34f9eee02fb13dca059865bed2ba2e728bc936a76
languageName: node
linkType: hard

Expand Down Expand Up @@ -11023,7 +11025,7 @@ __metadata:
"@tsd/typescript": ^4.9.5
"@types/jest": ^29.4.0
"@types/mock-fs": ^4.13.1
"@types/node": 16.18.13
"@types/node": 20.14.8
"@types/ramda": ^0.27.23
"@typescript-eslint/eslint-plugin": ^5.50.0
"@typescript-eslint/parser": ^5.50.0
Expand Down Expand Up @@ -15670,6 +15672,13 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~5.26.4":
version: 5.26.5
resolution: "undici-types@npm:5.26.5"
checksum: 3192ef6f3fd5df652f2dc1cd782b49d6ff14dc98e5dced492aa8a8c65425227da5da6aafe22523c67f035a272c599bb89cfe803c1db6311e44bed3042fc25487
languageName: node
linkType: hard

"unicode-canonical-property-names-ecmascript@npm:^2.0.0":
version: 2.0.0
resolution: "unicode-canonical-property-names-ecmascript@npm:2.0.0"
Expand Down
Loading