Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Guides section improvements #2063

Merged
merged 4 commits into from
Nov 4, 2024
Merged

docs: Guides section improvements #2063

merged 4 commits into from
Nov 4, 2024

Conversation

andrii-bodnar
Copy link
Contributor

@andrii-bodnar andrii-bodnar commented Oct 23, 2024 •
edited
Loading

Description

🖼️ Deployment Preview

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 31, 2024 0:25am

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.09 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
@andrii-bodnar andrii-bodnar removed the request for review from vonovak October 25, 2024 08:57
vonovak
vonovak reviewed Oct 29, 2024
View reviewed changes
website/docs/guides/dynamic-loading-catalogs.md Outdated Show resolved Hide resolved
website/docs/guides/explicit-vs-generated-ids.md Outdated Show resolved Hide resolved
website/docs/guides/message-extraction.md Outdated Show resolved Hide resolved
website/docs/guides/plurals.md Outdated Show resolved Hide resolved
@andrii-bodnar @vonovak
Apply suggestions from code review
0eac67c 
Co-authored-by: Vojtech Novak <vonovak@gmail.com>
@andrii-bodnar andrii-bodnar merged commit 716e5f4 into next Nov 4, 2024
9 of 10 checks passed
@andrii-bodnar andrii-bodnar deleted the docs/guides branch November 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak left review comments

@timofei-iatsenko timofei-iatsenko Awaiting requested review from timofei-iatsenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.
2 participants
@andrii-bodnar @vonovak