Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin): add support for vite@6 #2108

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

monholm
Copy link
Contributor

@monholm monholm commented Dec 5, 2024

Description

This PR widens the range of accepted peer dependency versions for vite in the vite-plugin to add support for vite@6.

We've been using vite@6 with the lingui vite-plugin without any issues since vite@6 was released.

I also updated the vite dev dependency to ensure that the type imported in the source code matches a newer version than v4 and ran yarn dedupe to clean up the lock file after the vite upgrade.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2103

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Dec 5, 2024 7:44am

@monholm monholm changed the title Vite 6 support feat(vite-plugin): add support for vite@6 Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.09 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (6bb8983) to head (3982071).
Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
- Coverage   77.05%   75.96%   -1.09%     
==========================================
  Files          84       87       +3     
  Lines        2157     2380     +223     
  Branches      555      621      +66     
==========================================
+ Hits         1662     1808     +146     
- Misses        382      456      +74     
- Partials      113      116       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monholm thank you!

@andrii-bodnar andrii-bodnar merged commit 38a0c6f into lingui:main Dec 5, 2024
10 of 12 checks passed
@monholm monholm deleted the vite-6-support branch December 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 6 support
3 participants