Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the stripMessageField instructions in the v5 launch post. #2136

Closed
wants to merge 1 commit into from

Conversation

trevorweng
Copy link

@trevorweng trevorweng commented Dec 24, 2024

Description

To use stripMessageField , you just need:

      [
        '@lingui/babel-plugin-lingui-macro',
        {
          stripMessageField: false,
        },
      ]

instead of

        {
          lingui: {
            stripMessageField: false,
          },
        },

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Dec 24, 2024 2:01am

Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.22 KB (0%)
./packages/detect-locale/dist/index.mjs 722 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@trevorweng trevorweng changed the title Fix a mistake in the stripMessageField instructions on v5 launch post Correct the stripMessageField instructions in the v5 launch post. Dec 24, 2024
@trevorweng trevorweng marked this pull request as ready for review December 24, 2024 05:02
@timofei-iatsenko
Copy link
Collaborator

Are you sure? It is not correct according to babel-macro documentation. What you wrote is correct for the babel-plugin-lingui-macro (a plugin, not a macro)

@trevorweng trevorweng closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants