Don't prevent babel options to help setup lingui in monorepos #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tricoder42 Is there any chance you could take a look at this PR :). Happy to modify to remove all validation of babel options. |
|
@adamscybot Ah, sorry, completely forgot about it. yeah, I had another problem with config validation before, so I'm gonna probably move away from jest-validate in the future. |
|
And thanks for the PR! 👍 |
|
Released in 2.7.4 |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, lingui complains with option validation issues if you attempt to use the
extendsorrootModebabel options. In a monorepo, with Babel 7, you often want message extraction to happen in each module, but using a common babel configuration that exists in a top level "workspace"We should allow these options without throwing warnings. I'm not sure we should actually have any validation on the babel options (since whats allowed depends on babel version, and theres not much need to limit he feature set) so potentially, this validation could be removed entirely.