Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dx warn on undefined id #874

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Nov 17, 2020

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/kv2ngh65c
✅ Preview: https://js-lingui-git-chore-improve-logging.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #874 (32d6c99) into main (d0b3eb5) will increase coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   82.76%   82.85%   +0.09%     
==========================================
  Files          51       51              
  Lines        1427     1435       +8     
  Branches      392      394       +2     
==========================================
+ Hits         1181     1189       +8     
  Misses        145      145              
  Partials      101      101              
Impacted Files Coverage Δ
...ackages/babel-plugin-extract-messages/src/index.ts 82.11% <50.00%> (-2.24%) ⬇️
packages/core/src/dev/loadLocaleData.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b3eb5...32d6c99. Read the comment docs.

Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏

@tricoder42 tricoder42 merged commit 43c7e39 into main Nov 18, 2020
@tricoder42 tricoder42 deleted the chore--improve-logging branch November 18, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants