Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add trailing slash to fix the url-based highlight issue #16

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix: add trailing slash to fix the url-based highlight issue #16

merged 3 commits into from
Oct 11, 2023

Conversation

S1ngS1ng
Copy link
Contributor

@S1ngS1ng S1ngS1ng commented Oct 11, 2023 •
edited
Loading

Reproduction

npm run dev

image

npm run build && npm run preview

image

RCA

See also:

Result

Chinese

image

English

image

Closes #13

@S1ngS1ng S1ngS1ng mentioned this pull request Oct 11, 2023
Closed
@PapayaHUANG PapayaHUANG merged commit ad06a52 into main Oct 11, 2023
1 check passed
@S1ngS1ng S1ngS1ng deleted the fix/navigation-highlight-issue branch October 11, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapayaHUANG PapayaHUANG PapayaHUANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar underline in accordance to page visited not working in production mode
2 participants
@S1ngS1ng @PapayaHUANG