Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Update benchmark #122

Merged
merged 5 commits into from
Sep 23, 2024
Merged

✅ Update benchmark #122

merged 5 commits into from
Sep 23, 2024

Conversation

linkdd
Copy link
Contributor

@linkdd linkdd commented Sep 23, 2024

Decision Record

The old benchmark written in Python was not working anymore (the data/ folder was getting overwritten). The benchmark in the End-To-End test suite did not really test anything, because the default pipeline does almost nothing.

Let's fix the Python benchmark, and improve it by allowing it to run requests in parallel.

See: #77

Changes

  • 🔥 Remove Hurl benchmark
  • 🐛 ✅ Fix Python benchmark
  • ✅ Allow benchmark to run requests in parallel
  • 📝 Update README with new test results

License Agreement

  • I guarantee that I have the rights on the code submitted in this PR
  • I accept that this contribution will be released under the terms of the MIT License

@linkdd linkdd added this to the 1.0.0 milestone Sep 23, 2024
@linkdd linkdd self-assigned this Sep 23, 2024
Copy link

sonarqubecloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
End-To-End Test Report11 ran11 passed0 skipped0 failed

@linkdd linkdd merged commit f8746dd into main Sep 23, 2024
4 checks passed
@linkdd linkdd deleted the bench branch September 23, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant