Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Pixtral Support #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreSlavescu
Copy link
Contributor

Summary

This PR aims to support pixtral

Testing Done

tested model + tested monkey patch

  • Hardware Type: 4090
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@AndreSlavescu
Copy link
Contributor Author

Pixtral isn't yet fully supported in transformers library. PR pending release of Pixtral in transformers package.

@ByronHsu ByronHsu mentioned this pull request Sep 30, 2024
@lancerts lancerts requested a review from ByronHsu October 2, 2024 00:19
@lancerts
Copy link
Collaborator

lancerts commented Oct 3, 2024

Exciting! @AndreSlavescu seems it is now supported in the transformer https://github.com/huggingface/transformers/tree/main/src/transformers/models/pixtral,
do you mind update the PR?

@AndreSlavescu
Copy link
Contributor Author

Exciting! @AndreSlavescu seems it is now supported in the transformer https://github.com/huggingface/transformers/tree/main/src/transformers/models/pixtral, do you mind update the PR?

yes, I'll try to finish this either today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants