Add ignore_index and label to jsd and fl-jsd #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yundai424
reviewed
Oct 15, 2024
src/liger_kernel/ops/jsd.py
Outdated
| tl.store(dX_ptr + offsets, dX, mask=mask) | ||
|
|
||
|
|
||
| MAX_FUSED_SIZE = 65536 | ||
|
|
||
|
|
||
| def jsd_forward(_input, target, beta): | ||
| def jsd_forward(_input, target, label, beta, ignore_index, has_label): |
There was a problem hiding this comment.
I might be wrong -- if i'm understanding it correctly, we currently have an intrinsic assumption that the label is shifted already. It would be helpful to specify this requirement and provide an example of what kind of input we'll expect in this case 🤔
There was a problem hiding this comment.
Makes sense. I added some examples in transformers files, and renamed it to shift_labels.
yundai424
requested changes
Oct 15, 2024
src/liger_kernel/ops/jsd.py
Outdated
| beta, | ||
| n_rows, | ||
| n_non_ignore, | ||
| ignore_index, |
There was a problem hiding this comment.
nit: this could be a constexpr
yundai424
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #277.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence